Add missing 'format' reserved model word. #8194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per conversation with Derrick, https://forum.strapi.io/t/simple-one-to-one-relation-throws-error/218, i created this PR |
derrickmehaffy
requested changes
Oct 5, 2020
| @@ -1,7 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| // contentTypes and components reserved names | |||
| const RESERVED_MODEL_NAMES = ['admin', 'boolean', 'date', 'date-time', 'time', 'upload']; | |||
| const RESERVED_MODEL_NAMES = ['admin', 'boolean', 'date', 'date-time', 'format', 'time', 'upload']; | |||
There was a problem hiding this comment.
It'll be a field name, not the model name. I've tested with model names and it's fine.
There was a problem hiding this comment.
RESERVED_ATTRIBUTE_NAME ??
Codecov Report
@@ Coverage Diff @@
## master #8194 +/- ##
==========================================
- Coverage 32.96% 32.95% -0.02%
==========================================
Files 1197 1197
Lines 13020 13027 +7
Branches 1286 1286
==========================================
+ Hits 4292 4293 +1
- Misses 7885 7891 +6
Partials 843 843
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
added
source: core:database
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Fixed issue where user was allowed to create a model with reserved word 'format'. Creating this model would then break one-to-one relationships and cause an error: "Maximum call stack size exceeded."