New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "has same role as author" condition not working properly #8202
Conversation
9c95eb8
to
2437e6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for some smol tests 👀
Codecov Report
@@ Coverage Diff @@
## master #8202 +/- ##
==========================================
- Coverage 33.03% 33.03% -0.01%
==========================================
Files 1219 1219
Lines 13563 13569 +6
Branches 1348 1348
==========================================
+ Hits 4481 4482 +1
- Misses 8200 8205 +5
Partials 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Since the errors are not unified in the app it's really difficult for the front-end to process them, this is why it doesn't catch the forbidden error. |
This will probably be something to address in the backend and unifying/standardizing our error response (I know the U&P plugin has some issues there) |
@derrickmehaffy here we can use the status code which are standard not the best message be forbidden is better than server error :) |
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
2437e6b
to
7505365
Compare
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
9af0ab0
to
3cce9ad
Compare
Description of what you did:
Conditions based on author's roles were not working properly. This PR aims to fix this behaviour.
fix #8129
About the
SERVER_ERROR
mentionned in the issue, the backend is sending back a403 Forbidden
error.@soupette / @HichamELBSI do you have any insight on this?