Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #8221 - fixed publish failing if non-repeateable component data is "null" #8222

Merged
merged 1 commit into from Oct 7, 2020

Conversation

Stanko
Copy link
Contributor

@Stanko Stanko commented Oct 7, 2020

Fixes #8220

In #8221 I explained the problem thoroughly, but it was closed as it is a duplicate of 8220.

Basically getDraftRelationsCount is called with null as data, and then Object.keys(data) fails on line 5

I'm pretty sure this doesn't affect other functionalities.

@alexandrebodin alexandrebodin added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Oct 7, 2020
@alexandrebodin alexandrebodin added this to the 3.2.1 milestone Oct 7, 2020
HichamELBSI
HichamELBSI previously approved these changes Oct 7, 2020
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution.

… is "null"

Signed-off-by: Stanko <stanko.tadic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot publish draft record when component field is null (v3.2.0)
3 participants