Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix D&P population #8249

Merged
merged 3 commits into from Oct 8, 2020
Merged

Fix D&P population #8249

merged 3 commits into from Oct 8, 2020

Conversation

Convly
Copy link
Member

@Convly Convly commented Oct 8, 2020

Fix D&P population (gql, rest, single-types)

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@Convly Convly added issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package labels Oct 8, 2020
@Convly Convly added this to the 3.2.2 milestone Oct 8, 2020
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #8249 into master will increase coverage by 0.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8249      +/-   ##
==========================================
+ Coverage   33.02%   33.04%   +0.01%     
==========================================
  Files        1219     1219              
  Lines       13568    13573       +5     
  Branches     1348     1348              
==========================================
+ Hits         4481     4485       +4     
- Misses       8205     8206       +1     
  Partials      882      882              
Flag Coverage Δ
#front 24.70% <ø> (ø)
#unit 54.13% <44.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi/lib/core-api/controller.js 28.26% <0.00%> (-1.29%) ⬇️
packages/strapi/lib/core-api/service.js 72.72% <100.00%> (+8.28%) ⬆️
packages/strapi/lib/services/entity-service.js 48.78% <100.00%> (ø)
packages/strapi-utils/lib/logger.js 65.00% <0.00%> (-11.48%) ⬇️
...n/services/permission/permissions-manager/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938f9fa...7780830. Read the comment docs.

alexandrebodin
alexandrebodin previously approved these changes Oct 8, 2020
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants