Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined pk #8260

Merged
merged 1 commit into from Oct 9, 2020
Merged

Fix undefined pk #8260

merged 1 commit into from Oct 9, 2020

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Oct 9, 2020

Signed-off-by: Alexandre Bodin bodin.alex@gmail.com

Description of what you did:

bad column generated on startup for many way rels

fixes #8258

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin added source: core:database Source is core/database package issue: bug Issue reporting a bug labels Oct 9, 2020
@alexandrebodin alexandrebodin added this to the 3.2.3 milestone Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #8260 into master will increase coverage by 0.01%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8260      +/-   ##
==========================================
+ Coverage   33.02%   33.04%   +0.01%     
==========================================
  Files        1219     1219              
  Lines       13568    13573       +5     
  Branches     1348     1348              
==========================================
+ Hits         4481     4485       +4     
- Misses       8205     8206       +1     
  Partials      882      882              
Flag Coverage Δ
#front 24.70% <ø> (ø)
#unit 54.13% <47.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugin-content-manager/controllers/ContentManager.js 21.67% <0.00%> (ø)
packages/strapi/lib/core-api/controller.js 28.26% <0.00%> (-1.29%) ⬇️
packages/strapi-utils/lib/logger.js 65.00% <42.85%> (-11.48%) ⬇️
...n/services/permission/permissions-manager/index.js 100.00% <100.00%> (ø)
packages/strapi/lib/core-api/service.js 72.72% <100.00%> (+8.28%) ⬆️
packages/strapi/lib/services/entity-service.js 48.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d0b72...55f12e5. Read the comment docs.

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

database getting _undefined in one way hasMany relations
2 participants