Don't use mongoose 5.10.7 #8278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolved strapi#8066 Signed-off-by: Jonas De Kegel <jonas@fluid.desi>
Codecov Report
@@ Coverage Diff @@
## master #8278 +/- ##
==========================================
+ Coverage 33.02% 33.04% +0.01%
==========================================
Files 1219 1219
Lines 13568 13573 +5
Branches 1348 1348
==========================================
+ Hits 4481 4485 +4
- Misses 8205 8206 +1
Partials 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
approved these changes
Oct 13, 2020
alexandrebodin
added
source: core:database
|
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1 |
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8066
Signed-off-by: Jonas De Kegel jonas@fluid.desi
Description of what you did:
bumped mongoose to 5.10.8 as requested here AND manually ensure 5.10.7 was not used in yarn.lock (for some reason yarn kept resolving
^5.5.13to 5.10.7 even though it was the only remaining 5.10.7 usage (it should've switched to 5.10.8); manually updating the yarn.lock did make yarn see this, also after subsequent changes (but it will be important to check this on merge if there are lock conflicts)