Fix validations for custom field types #8297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Williams <spwilliams91@icloud.com>
sam899
force-pushed
the
hotfix/support-custom-field-types
branch
from
7c2f24d
to
92b71d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #8297 +/- ##
=======================================
Coverage 33.04% 33.05%
=======================================
Files 1219 1219
Lines 13573 13576 +3
Branches 1348 1350 +2
=======================================
+ Hits 4485 4487 +2
Misses 8206 8206
- Partials 882 883 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petersg83
added
source: core:strapi
|
|
||
| const input = { uuid: '2479d6d7-2497-478d-8a34-a9e8ce45f8a7' }; | ||
|
|
||
| expect.hasAssertions(); |
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8294
With the new draft/publish system, models with custom field types could no longer be saved.
(Custom field types described here)
When trying to create or update a model with an un-handled attribute type, the API would give a 500 internal server error, as no validator exists for this attribute type.
This PR handles the case where a custom validator is not available for a specific attribute type, and instead of throwing an error, falls back to using a mixed type validator.