Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset admin password CLI #8311

Merged
merged 4 commits into from Oct 14, 2020
Merged

Reset admin password CLI #8311

merged 4 commits into from Oct 14, 2020

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Oct 13, 2020

Description of what you did:

Add the admin:reset-password command. Might rename it before merging though.

Documentation to review by before merging @derrickmehaffy

@alexandrebodin alexandrebodin added source: cli Source is cli package issue: feature request Issue suggesting a new feature labels Oct 13, 2020
@alexandrebodin alexandrebodin added this to the 3.2.4 milestone Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #8311 into master will increase coverage by 0.15%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8311      +/-   ##
==========================================
+ Coverage   33.04%   33.20%   +0.15%     
==========================================
  Files        1219     1220       +1     
  Lines       13573    13610      +37     
  Branches     1348     1355       +7     
==========================================
+ Hits         4485     4519      +34     
- Misses       8206     8208       +2     
- Partials      882      883       +1     
Flag Coverage Δ
#front 24.72% <0.00%> (+0.02%) ⬆️
#unit 54.48% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-manager/admin/src/components/InputUID/InputUID.js 0.00% <0.00%> (ø)
...ent-manager/admin/src/components/InputUID/index.js 0.00% <ø> (ø)
packages/strapi-admin/services/user.js 83.89% <100.00%> (+1.32%) ⬆️
packages/strapi/lib/commands/admin-reset.js 100.00% <100.00%> (ø)
...ages/strapi/lib/services/entity-validator/index.js 55.17% <100.00%> (+1.05%) ⬆️
...kages/strapi-admin/admin/src/translations/index.js 100.00% <0.00%> (ø)
...trapi-admin/admin/src/containers/HomePage/index.js 62.50% <0.00%> (ø)
...-users-permissions/admin/src/translations/index.js 0.00% <0.00%> (ø)
.../src/containers/InputModalStepperProvider/index.js 0.00% <0.00%> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc40a3...8af6025. Read the comment docs.

@alexandrebodin alexandrebodin marked this pull request as ready for review October 13, 2020 13:25
@alexandrebodin alexandrebodin requested a review from a team as a code owner October 13, 2020 13:25
derrickmehaffy
derrickmehaffy previously approved these changes Oct 13, 2020
await passwordValidator.validate(password);
} catch (error) {
throw new Error(
'Invalid password. Expected a minimum of 8 characters with at least one number and one uppercase letter'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a symbol no?

soupette
soupette previously approved these changes Oct 14, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some questions

packages/strapi/bin/strapi.js Outdated Show resolved Hide resolved
packages/strapi/bin/strapi.js Outdated Show resolved Hide resolved
packages/strapi/lib/commands/admin-reset.js Show resolved Hide resolved
packages/strapi/lib/commands/admin-reset.js Show resolved Hide resolved
packages/strapi/lib/commands/admin-reset.js Show resolved Hide resolved
packages/strapi/lib/commands/admin-reset.js Show resolved Hide resolved
packages/strapi-admin/services/user.js Show resolved Hide resolved
packages/strapi-admin/services/user.js Outdated Show resolved Hide resolved
packages/strapi-admin/services/__tests__/user.test.js Outdated Show resolved Hide resolved
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 8b212d1 into master Oct 14, 2020
@alexandrebodin alexandrebodin deleted the cli/reset-admin-pwd branch October 14, 2020 12:53
@lauriejim
Copy link
Contributor

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/problem-recover-password/454/2

@lauriejim
Copy link
Contributor

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1

@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/cant-login-using-password-reset/8992/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Issue suggesting a new feature source: cli Source is cli package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants