New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset admin password CLI #8311
Reset admin password CLI #8311
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8311 +/- ##
==========================================
+ Coverage 33.04% 33.20% +0.15%
==========================================
Files 1219 1220 +1
Lines 13573 13610 +37
Branches 1348 1355 +7
==========================================
+ Hits 4485 4519 +34
- Misses 8206 8208 +2
- Partials 882 883 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
await passwordValidator.validate(password); | ||
} catch (error) { | ||
throw new Error( | ||
'Invalid password. Expected a minimum of 8 characters with at least one number and one uppercase letter' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a symbol no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4631ea2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, some questions
4631ea2
to
a907f8a
Compare
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
a907f8a
to
8af6025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on Strapi Community. There might be relevant details there: |
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1 |
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/cant-login-using-password-reset/8992/5 |
Description of what you did:
Add the
admin:reset-password
command. Might rename it before merging though.Documentation to review by before merging @derrickmehaffy