New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Academy link to the 'Join the community' card in the homepage #8316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime Castres <mcastres@student.42.fr>
Mcastres
force-pushed
the
enhancement/academy-link
branch
from
October 13, 2020 12:53
a2534ef
to
23de612
Compare
HichamELBSI
requested changes
Oct 13, 2020
packages/strapi-admin/admin/src/containers/HomePage/SocialLink.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxime Castres <mcastres@student.42.fr>
Signed-off-by: Maxime Castres <mcastres@student.42.fr>
HichamELBSI
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll let you update and merge this branch |
alexandrebodin
added
source: core:admin
Source is core/admin package
issue: enhancement
Issue suggesting an enhancement to an existing feature
labels
Oct 13, 2020
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
issue: enhancement
Issue suggesting an enhancement to an existing feature
source: core:admin
Source is core/admin package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
I added a link to the academy in the "Join the community" card in the homepage