Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong permissions assigns (upload, users-permissions) #8320

Merged
merged 1 commit into from Oct 13, 2020

Conversation

Convly
Copy link
Member

@Convly Convly commented Oct 13, 2020

fix #8206

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@Convly Convly requested a review from a team as a code owner October 13, 2020 14:49
@Convly Convly added source: core:strapi Source is core/strapi package issue: bug Issue reporting a bug labels Oct 13, 2020
@Convly Convly added this to the 3.2.4 milestone Oct 13, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works fine. We might want to add a comment in the next release so users checks those permissions are set correctly :)

@alexandrebodin
Copy link
Member

alexandrebodin commented Oct 13, 2020

Merging when tests will end

Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, it works well :)

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #8320 into master will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8320   +/-   ##
=======================================
  Coverage   33.04%   33.05%           
=======================================
  Files        1219     1219           
  Lines       13573    13578    +5     
  Branches     1348     1350    +2     
=======================================
+ Hits         4485     4488    +3     
- Misses       8206     8207    +1     
- Partials      882      883    +1     
Flag Coverage Δ
#front 24.70% <33.33%> (+<0.01%) ⬆️
#unit 54.15% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-admin/admin/src/containers/HomePage/SocialLink.js 100.00% <ø> (ø)
...trapi-admin/admin/src/containers/HomePage/index.js 62.50% <ø> (ø)
...-manager/admin/src/components/InputUID/InputUID.js 0.00% <0.00%> (ø)
...ent-manager/admin/src/components/InputUID/index.js 0.00% <ø> (ø)
...-users-permissions/admin/src/translations/index.js 0.00% <0.00%> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <100.00%> (ø)
...ages/strapi/lib/services/entity-validator/index.js 55.17% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e836a...e9750f8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong permissions applied to upload plugin
3 participants