New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong permissions assigns (upload, users-permissions) #8320
Conversation
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works fine. We might want to add a comment in the next release so users checks those permissions are set correctly :)
Merging when tests will end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, it works well :)
Codecov Report
@@ Coverage Diff @@
## master #8320 +/- ##
=======================================
Coverage 33.04% 33.05%
=======================================
Files 1219 1219
Lines 13573 13578 +5
Branches 1348 1350 +2
=======================================
+ Hits 4485 4488 +3
- Misses 8206 8207 +1
- Partials 882 883 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fix #8206