New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support query operators _or & _where in graphql with deep nesting #8332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, nice!
Could you just add a test in graphqlCrud.test.e2e
> List posts with where clause %o
with an or
clause?
confirmed issue though with this: #8331 not sure if this will hold back this PR or not |
@derrickmehaffy not related as this only fixed the querying in graphql not passing the parameters correctly |
15941e3
to
e28f5da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice addition!
Codecov Report
@@ Coverage Diff @@
## master #8332 +/- ##
=======================================
Coverage 33.20% 33.20%
=======================================
Files 1220 1220
Lines 13610 13614 +4
Branches 1355 1357 +2
=======================================
+ Hits 4519 4521 +2
Misses 8208 8208
- Partials 883 885 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
e28f5da
to
e253f7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1 |
Signed-off-by: Alexandre Bodin bodin.alex@gmail.com
Description of what you did:
Fixes #8322