Fix incorrect openapi type for datetime, date and password

[henrych4]

Signed-off-by: henrych4 singyinhenry@gmail.com

Description of what you did:

Reopen #7623 and update with respect to the comments to fix #7149

[codecov]

Codecov Report

Merging #8334 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8334      +/-   ##
==========================================
- Coverage   33.20%   33.19%   -0.01%     
==========================================
  Files        1220     1220              
  Lines       13616    13618       +2     
  Branches     1356     1357       +1     
==========================================
  Hits         4521     4521              
- Misses       8211     8212       +1     
- Partials      884      885       +1     

Flag	Coverage Δ
#front	24.72% <ø> (ø)
#unit	54.45% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/strapi-utils/lib/models.js	25.00% <0.00%> (-0.32%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b62d98...148c4c0. Read the comment docs.

[petersg83]

Thanks for you contribution ! I have some remarks :)

[petersg83]

I would suggest to just modify the else block.
Something like:

        } else {
          acc.properties[current] = {
            type,
            format: getFormat(attribute.type),
            description,
            default: defaultValue,
            minimum,
            maxmimun,
            maxLength,
            minLength,
            enum: enumeration,
          };
        }

(In your code the value of type is 'string' for date and password, so it would not work for those two. The right variable to use would be attribute.type.)

(I think we need to modify the function getType so it handles datetime)

[henrych4]

Updated. Thanks for the comment, the code looks much better now.

[petersg83]

Can you make the handling of date and password explicit please? And make the default value undefined as the function would be wrong for other types.

Something like:

  getFormat: type => {
    switch (type) {
      case 'date':
        return 'date';
      case 'datetime':
        return 'date-time';
      case 'password':
        return 'password';
      default:
        return undefined;
    }
  },

[petersg83]

No need to remove password and date. Just to add datetime here :)

[petersg83]

@henrych4 You forgot to add datetime :)

[petersg83]

Thank you ! I tested it, it works well :)
While testing I saw that the type time was not handled neither in getType. Can you just add case 'time:' at the same place as case 'datetime' please ? :) No need to update getFormat as doesn't this it has an official format.

[petersg83]

Thank you, nice addition ! :)