Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deepFiltering with draft & publish #8356

Merged
merged 3 commits into from Oct 20, 2020
Merged

Fix deepFiltering with draft & publish #8356

merged 3 commits into from Oct 20, 2020

Conversation

Convly
Copy link
Member

@Convly Convly commented Oct 16, 2020 •
edited

Handle draft & publish for the deep filtering.
Prevent search & filters on draft content.

fix #8331

@Convly Convly added issue: bug Issue reporting a bug source: core:database Source is core/database package labels Oct 16, 2020
@Convly Convly added this to the 3.2.4 milestone Oct 16, 2020
@Convly Convly requested a review from a team as a code owner October 16, 2020 09:33
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited

Codecov Report

Merging #8356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8356   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files        1220     1220           
  Lines       13618    13618           
  Branches     1357     1357           
=======================================
  Hits         4521     4521           
  Misses       8212     8212           
  Partials      885      885
Flag Coverage Δ
#front 24.72% <ø> (ø)
#unit 54.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad9fda...07c3842. Read the comment docs.

@alexandrebodin alexandrebodin modified the milestones: 3.2.4, 3.2.5 Oct 16, 2020
@Convly
Fix deepFiltering with draft & publish
03f5342 
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@Convly
Remove unnecessary custom option from query
e1e2dd3 
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@Convly
Fix buildQuery for polymorphic relations
07c3842 
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
alexandrebodin
alexandrebodin approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit b1aa7b9 into master Oct 20, 2020
@alexandrebodin alexandrebodin deleted the fix/dp-deep-filtering branch October 20, 2020 12:03
This was referenced Mar 10, 2021
Open
Open
This was referenced Mar 18, 2021
Closed
Closed
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 14, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Milestone
3.2.5
Development

Successfully merging this pull request may close these issues.

Deep filtering doesn't ignore draft entries
2 participants
@Convly @alexandrebodin