Add confirmationToken to user for email confirmation #8365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8365 +/- ##
==========================================
- Coverage 33.20% 33.19% -0.01%
==========================================
Files 1220 1220
Lines 13616 13618 +2
Branches 1356 1357 +1
==========================================
Hits 4521 4521
- Misses 8211 8212 +1
- Partials 884 885 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
force-pushed
the
fix/email-confirmation-jwt
branch
2 times, most recently
from
c132b90
to
ae61688
Compare
derrickmehaffy
previously approved these changes
Oct 16, 2020
meganelacheny
previously approved these changes
Oct 16, 2020
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
alexandrebodin
dismissed stale reviews from meganelacheny and derrickmehaffy
via
529d147
alexandrebodin
force-pushed
the
fix/email-confirmation-jwt
branch
from
ae61688
to
529d147
Compare
petersg83
suggested changes
Oct 16, 2020
| const decodedToken = await strapi.plugins['users-permissions'].services.jwt.verify( | ||
| params.confirmation | ||
| ); | ||
| const { user: userServie, jwt: jwtService } = strapi.plugins['users-permissions'].services; |
| } | ||
| ``` | ||
|
|
||
| That's it now you can follow the basic [version update guide](../guides/update-version.md). |
There was a problem hiding this comment.
What about adding a coma : That's it, now you can follow the basic ...?
petersg83
added
the
source: plugin:users-permissions
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
|
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1 |
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexandre Bodin bodin.alex@gmail.com
What does it do?
Adds a confirmationToken to use in the email confirmation instead of a valid jwt token.
We will need to explain how to add this field manually for users that did extend the User model. Will create a specific migration guide