Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt README.md because NodeJS 14 is supported now #8417

Merged
merged 1 commit into from Oct 22, 2020

Conversation

bykof
Copy link
Contributor

@bykof bykof commented Oct 21, 2020

NodeJS 14 is supported now, so remove the hint that it's not supported

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

NodeJS 14 is supported now, so remove the hint that it's not supported
@bykof bykof requested a review from a team as a code owner October 21, 2020 11:34
@alexandrebodin alexandrebodin requested review from derrickmehaffy and removed request for a team October 21, 2020 11:35
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #8417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8417   +/-   ##
=======================================
  Coverage   33.27%   33.27%           
=======================================
  Files        1220     1220           
  Lines       13625    13625           
  Branches     1357     1357           
=======================================
  Hits         4534     4534           
  Misses       8207     8207           
  Partials      884      884           
Flag Coverage Δ
#front 24.72% <ø> (ø)
#unit 54.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c684d...838b8ac. Read the comment docs.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

README.md Show resolved Hide resolved
@alexandrebodin alexandrebodin merged commit 1149f8c into strapi:master Oct 22, 2020
@alexandrebodin alexandrebodin added this to the 3.2.5 milestone Oct 22, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Oct 22, 2020
@bykof bykof deleted the patch-1 branch October 22, 2020 16:25
@laurenskling
Copy link
Contributor

Shouldn't it be <15 to say 14 is supported?

@bykof
Copy link
Contributor Author

bykof commented Oct 22, 2020

Shouldn't it be <15 to say 14 is supported?

yes you are right

@bykof bykof restored the patch-1 branch October 22, 2020 17:03
@bykof
Copy link
Contributor Author

bykof commented Oct 22, 2020

@laurenskling i created a new PR: #8446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants