Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission to CTB routes #8439

Merged
merged 1 commit into from Oct 22, 2020
Merged

Add permission to CTB routes #8439

merged 1 commit into from Oct 22, 2020

Conversation

Convly
Copy link
Member

@Convly Convly commented Oct 22, 2020

No description provided.

@Convly Convly added issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package labels Oct 22, 2020
@Convly Convly added this to the 3.2.5 milestone Oct 22, 2020
@Convly Convly requested a review from a team as a code owner October 22, 2020 13:53
@Convly
Add permission to CTB routes
15e8a76 
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@codecov
Copy link

codecov bot commented Oct 22, 2020 •
edited

Codecov Report

Merging #8439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8439   +/-   ##
=======================================
  Coverage   33.27%   33.27%           
=======================================
  Files        1220     1220           
  Lines       13625    13625           
  Branches     1357     1357           
=======================================
  Hits         4534     4534           
  Misses       8207     8207           
  Partials      884      884
Flag Coverage Δ
#front 24.72% <ø> (ø)
#unit 54.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d00bc0...15e8a76. Read the comment docs.

@alexandrebodin alexandrebodin removed the request for review from a team October 22, 2020 13:59
@alexandrebodin alexandrebodin added issue: security Issue reporting a security problem and removed issue: bug Issue reporting a bug labels Oct 22, 2020
alexandrebodin
alexandrebodin approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice

@alexandrebodin alexandrebodin merged commit 3cdd739 into master Oct 22, 2020
@alexandrebodin alexandrebodin deleted the fix/ctb-permissions branch October 22, 2020 14:30
This was referenced Mar 10, 2021
Open
Open
This was referenced Mar 18, 2021
Closed
Closed
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 14, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees
No one assigned
Labels
issue: security Issue reporting a security problem source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.2.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Convly @alexandrebodin