Remove usage of unsecure proxy for now #8442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
added
source: core:upload
alexandrebodin
requested review from
Convly and
soupette
and removed request for
a team
soupette
reviewed
Oct 22, 2020
| @@ -85,7 +85,7 @@ const InputModalStepperProvider = ({ | |||
| const { source } = file; | |||
|
|
|||
| return axios | |||
| .get(`${strapi.backendURL}/${pluginId}/proxy?url=${file.fileURL}`, { | |||
| .get(file.fileURL, { | |||
There was a problem hiding this comment.
I don't think we need the Authorization headers
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
alexandrebodin
force-pushed
the
security/upload-proxy-disable
branch
from
1529b8a
to
fbf8313
Compare
Codecov Report
@@ Coverage Diff @@
## master #8442 +/- ##
=======================================
Coverage 33.26% 33.26%
=======================================
Files 1221 1221
Lines 13629 13629
Branches 1357 1357
=======================================
Hits 4534 4534
Misses 8211 8211
Partials 884 884
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
soupette
approved these changes
Oct 22, 2020
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexandre Bodin bodin.alex@gmail.com
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request