-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fix type singleType findOne #8764
Docs fix type singleType findOne #8764
Conversation
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
028fdfa
to
b021e8a
Compare
hi @fadhilx can you sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The find method has a different param :)
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
ce30d30
to
6f746eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fadhilx only thing pending is the CLA, there is an automated message at the top of the PR, can you click the button and sign that and I'll be able to merge. |
@derrickmehaffy done |
What does it do?
fix doc typo for singleType in services.md, specifically at createOrUpdate section
Why is it needed?
currently when i try to follow createOrUpdate, i got error
findOne is not a function
. so i know this is a typo because it related to #7721Related issue(s)/PR(s)
Issue: #7718
PR: #7721
PR attempt: #8763