Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fix type singleType findOne #8764

Merged

Conversation

fadhilx
Copy link
Contributor

@fadhilx fadhilx commented Nov 28, 2020

What does it do?

fix doc typo for singleType in services.md, specifically at createOrUpdate section

Why is it needed?

currently when i try to follow createOrUpdate, i got error findOne is not a function. so i know this is a typo because it related to #7721

Related issue(s)/PR(s)

Issue: #7718
PR: #7721

PR attempt: #8763

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@strapi-cla
Copy link

strapi-cla commented Nov 30, 2020

CLA assistant check
All committers have signed the CLA.

@derrickmehaffy
Copy link
Member

hi @fadhilx can you sign the CLA

derrickmehaffy
derrickmehaffy previously approved these changes Nov 30, 2020
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The find method has a different param :)

docs/v3.x/concepts/services.md Outdated Show resolved Hide resolved
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickmehaffy
Copy link
Member

@fadhilx only thing pending is the CLA, there is an automated message at the top of the PR, can you click the button and sign that and I'll be able to merge.

@fadhilx
Copy link
Contributor Author

fadhilx commented Dec 4, 2020

@derrickmehaffy done

@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Dec 4, 2020
@alexandrebodin alexandrebodin added this to the 3.3.5 milestone Dec 4, 2020
@alexandrebodin alexandrebodin merged commit b84aa2f into strapi:documentation Dec 4, 2020
@alexandrebodin alexandrebodin modified the milestones: 3.3.5, 4.0.0, 3.4.0 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants