-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added norwegian translation. #9846
Conversation
Kenneth Solberg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## master #9846 +/- ##
==========================================
+ Coverage 35.90% 35.91% +0.01%
==========================================
Files 1342 1342
Lines 14812 14815 +3
Branches 1477 1477
==========================================
+ Hits 5318 5321 +3
Misses 8575 8575
Partials 919 919
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, can you also update the index.js file so the Norwegian translation is available in the dropdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution.
Hello @ksolberg can you please sign the CLA so we can your PR :) |
@alexandrebodin hm, I clicked the sign button and got the confirmation, but here it still says not signed yet? What am I doing wrong? |
I thing your commit email address isn't the same as your github account so it doesn't recognize you :/ |
@alexandrebodin ah ofc. Got mixed with work email which is not a gh account. Amended the last commit, but need to amend all it seems. Easier to create a new pull request it seems and discard this one. Ok with that? |
As you wish :) You can rebase to make one commit with the right author too if your prefer :) |
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request