Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added norwegian translation. #9846

Merged
merged 4 commits into from
May 11, 2021
Merged

Added norwegian translation. #9846

merged 4 commits into from
May 11, 2021

Conversation

ksolberg
Copy link
Contributor

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@strapi-cla
Copy link

strapi-cla commented Mar 26, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ksolberg
❌ Kenneth Solberg


Kenneth Solberg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #9846 (d8e34b1) into master (b7bd30b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d8e34b1 differs from pull request most recent head 5cdb285. Consider uploading reports for the commit 5cdb285 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9846      +/-   ##
==========================================
+ Coverage   35.90%   35.91%   +0.01%     
==========================================
  Files        1342     1342              
  Lines       14812    14815       +3     
  Branches     1477     1477              
==========================================
+ Hits         5318     5321       +3     
  Misses       8575     8575              
  Partials      919      919              
Flag Coverage Δ
front 27.27% <100.00%> (+0.02%) ⬆️
unit 55.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/strapi-admin/admin/src/translations/index.js 100.00% <100.00%> (ø)
...ntent-manager/admin/src/utils/removeKeyInObject.js 91.66% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bd30b...5cdb285. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, can you also update the index.js file so the Norwegian translation is available in the dropdown?

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for your contribution.

@alexandrebodin
Copy link
Member

Hello @ksolberg can you please sign the CLA so we can your PR :)

@ksolberg
Copy link
Contributor Author

@alexandrebodin hm, I clicked the sign button and got the confirmation, but here it still says not signed yet? What am I doing wrong?

@alexandrebodin
Copy link
Member

I thing your commit email address isn't the same as your github account so it doesn't recognize you :/

@ksolberg
Copy link
Contributor Author

@alexandrebodin ah ofc. Got mixed with work email which is not a gh account. Amended the last commit, but need to amend all it seems. Easier to create a new pull request it seems and discard this one. Ok with that?

@alexandrebodin
Copy link
Member

As you wish :) You can rebase to make one commit with the right author too if your prefer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants