wip: Initial work for first class pydantic usage #3268
Conversation
| ) | ||
| ) | ||
|
|
||
| return fields |
There was a problem hiding this comment.
the code itself is quite simple for now!
| # Or just store them in a dict rather than on the model itself. | ||
| @pytest.mark.xfail(reason="Need to fix this") | ||
| def test_both_output_and_input_type(): | ||
| @first_class(name="WorkInput", is_input=True) |
There was a problem hiding this comment.
marked failing things in test_basic.py with xfail
There was a problem hiding this comment.
One problem is when your pydantic type needs to be both a Input and Output type. Now you can't mark them with the same decorator - because that will override the existing __strawberry_definition__.
|
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text: |
1 similar comment
|
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
- Coverage 96.60% 96.40% -0.20%
==========================================
Files 482 486 +4
Lines 29954 30633 +679
Branches 3694 3783 +89
==========================================
+ Hits 28937 29533 +596
- Misses 833 915 +82
- Partials 184 185 +1 |
CodSpeed Performance ReportMerging #3268 will not alter performanceComparing Summary
|
| class Query: | ||
| @strawberry.field | ||
| def user(self) -> User: | ||
| return User(id=1, name="Patrick") |
There was a problem hiding this comment.
this is how you use the api @patrick91 .
- decorate it
- Return it in your Query class
thejaminator
changed the title
thejaminator
force-pushed
the
first-class-init
branch
from
1cb57b7
to
a4bc9ae
Compare
for more information, see https://pre-commit.ci
| reason="""No way to manually handle errors | ||
| the validation goes boom in convert_argument, not in the create_user resolver""" | ||
| ) | ||
| def test_mutation_with_validation_and_error_type(): |
There was a problem hiding this comment.
issue 2: no way to manually handle validation errors for now
Initial work that allows you to use pydantic classes out of the box, without converting it into a strawberry dataclass type.
Start of #2181
What works
What doesn't work (Alot of things, don't use this yet)
What is tested so far
Two issues I encountered while implementing
__strawberry_definition__. When you register it as a input type, and after an output type, that original definition for the input type gets overwritten. wip: Initial work for first class pydantic usage #3268 (comment)Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist