Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input extensions #3297

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

basvandriel
Copy link
Contributor

Basic dict support for input extensions, to support automatic persisted queries in the future. See #1707.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Dec 17, 2023

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Related to #1707. This requires support for the underneath example in the curl command. See the documentation here.

curl --get http://localhost:4000/graphql \
  --header 'content-type: application/json' \
  --data-urlencode 'extensions={"persistedQuery":{"version":1,"sha256Hash":"ecf4edb46db40b5132295c0291d62fb65d6759a9eedfa4d5d612dd5ec54a6b38"}}'

Here's the tweet text:

🆕 Release (next) is out! Thanks to @bvandriel for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

Copy link

codspeed-hq bot commented Dec 17, 2023

CodSpeed Performance Report

Merging #3297 will not alter performance

Comparing basvandriel:feature/inputextensions (c807d44) with main (aad305b)

Summary

✅ 11 untouched benchmarks

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #3297 (3587bd3) into main (e4fe4fc) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
- Coverage   96.61%   96.41%   -0.21%     
==========================================
  Files         483      483              
  Lines       30188    30197       +9     
  Branches     3729     3731       +2     
==========================================
- Hits        29167    29115      -52     
- Misses        832      893      +61     
  Partials      189      189              

@basvandriel
Copy link
Contributor Author

Can someone take a look at this PR? Tests in tests/websockets/test_graphql_transport_ws.py seem to be failing in the CI which I can't replicate locally. cc @patrick91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants