Regenerate certs with SHA256 to fix test with Go 1.18+ #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes "x509: cannot verify signature: insecure algorithm SHA1-RSA" error with Go 1.18 and up in TestTLSHandshake.
|
Team RabbitMQ no longer pays any attention to this fork. Consider switching to, and submitting your PRs again, https://github.com/rabbitmq/amqp091-go/. |
|
For the record (because I have forgotten too), an equivalent PR was submitted on the same day (April 6, 2022) to https://github.com/rabbitmq/amqp091-go as rabbitmq/amqp091-go#66 (which was approved and merged on the same day) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "x509: cannot verify signature: insecure algorithm SHA1-RSA"
error with Go 1.18 and up in TestTLSHandshake.
Thanks to @lnussbaum for the bug report; see https://bugs.debian.org/1008423