Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): react-devtools build folder was ignored #4881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blackxored
Copy link
Contributor

React DevTools build folder was ignored from one of our global patterns. Didn't realize this until I had to reclone the repo.

Copy link

bundlemon bot commented Feb 27, 2024

BundleMon

Unchanged files (4)
Status Path Size Limits
renderer.(hash).js
6.72MB -
vendors~renderer.(hash).js
4.69MB -
updater.js
115.28KB -
guest-api.js
40.19KB -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@blackxored
Copy link
Contributor Author

blackxored commented Feb 27, 2024

There's a CSRF issue identified so it might not be as simple of a review. I don't believe the param is actually user-provided but dynamically generated by the extension to work, looking like a false positive. That said, considering this and also that React Devtools doesn't work without allowFileAccess we should take extra care.

EDIT: marked as on hold converted to Draft to avoid merge.

@blackxored blackxored marked this pull request as draft February 27, 2024 23:10
@blackxored blackxored marked this pull request as ready for review May 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants