Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 馃悰 throw when creating root directory #326

Merged
merged 2 commits into from Feb 9, 2019
Merged

fix: 馃悰 throw when creating root directory #326

merged 2 commits into from Feb 9, 2019

Conversation

streamich
Copy link
Owner

closes #325

@streamich streamich merged commit b765ff8 into master Feb 9, 2019
@streamich streamich deleted the fix-mkdir branch February 9, 2019 20:06
@streamich
Copy link
Owner Author

馃帀 This PR is included in version 2.15.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

sodatea added a commit to sodatea/webpack that referenced this pull request Mar 12, 2020
@sodatea
fix: also check for "EISDIR" in mkdirp
32d1bdf 
Fixes webpack#10544.

Though the `EISDIR` error code is not mentioned in the POSIX standard,
FreeBSD and memfs both throws this error when trying to run `mkdir` on
`/`. So essentially we should treat it the same as `EEXIST`.

References:
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=59739
* streamich/memfs#326
@sodatea sodatea mentioned this pull request Mar 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

creates undefined directories
1 participant
@streamich