Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy static properties from fs onto ufs #713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

phated
Copy link

@phated phated commented Mar 15, 2022

Thank you for this awesome library! 馃檹

I've been using it to fuse memfs and node's fs for use with the wasmer-js project (before they rewrote it in rust) and found that a few properties were missing on the final fs object.

This assigns the values when you use an fs (so the latest is copied).

@phated
Copy link
Author

phated commented Mar 15, 2022

An alternative implementation I considered was using getters and a loop lookup from each fss, but then you can't accurately detect a missing property and the getters would have to throw if the no fss provided the property.

@G-Rath
Copy link
Collaborator

G-Rath commented Jun 2, 2023

@phated would you mind rebasing so that the new CI changes are picked up?

@phated
Copy link
Author

phated commented Jun 26, 2023

@G-Rath I used the "sync fork" button in the github UI but it seems to have merged correctly. Let me know if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants