[Prototype] Add key parameter to st.container
#8569
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
changed the title
key parameter to st.containerkey parameter to st.container
LukasMasuch
changed the title
key parameter to st.containerkey parameter to st.container
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def current_container_key(this_dg: DeltaGenerator) -> str | None: | ||
| """Find the container key for the given DeltaGenerator.""" | ||
| # Avoid circular imports. | ||
| from streamlit.delta_generator import dg_stack |
Check notice
Code scanning / CodeQL
Cyclic import Note
|
Great, it will simplify a lot CSS interface customisation, Any plan for that ? Thanks |
LukasMasuch
commented
May 3, 2024
| @@ -29,11 +31,18 @@ | |||
|
|
|||
| SpecType: TypeAlias = Union[int, Sequence[Union[int, float]]] | |||
|
|
|||
| # Pattern to validate a container key (to be compatible with css class names): | |||
| _KEY_PATTERN: Final = re.compile(r"^[a-zA-Z_][a-zA-Z0-9\-_]*$") | |||
There was a problem hiding this comment.
The check here that it starts with a letter is not needed since we prefix the key anyways with some letters (e.g. st-)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.