Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support exchange bind exchange #701

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

gaoran10
Copy link
Collaborator

@gaoran10 gaoran10 commented Oct 20, 2022

Motivation

The RabbitMQ support exchange bind to exchange through plugins, refer to https://www.rabbitmq.com/e2e.html.
It's a useful feature, it supports complex data routing topology, such as below.

exchange-a -> exchange-b -> queue1
          |-> exchange-c -> queue1
                        |-> queue2

Modifications

Add two new methods in the ExchangeService interface.

CompletableFuture<Void> exchangeBind(NamespaceName namespaceName, String destination, String source,
                                         String routingKey, Map<String, Object> params);

CompletableFuture<Void> exchangeUnbind(NamespaceName namespaceName, String destination, String source,
                                         String routingKey, Map<String, Object> params);

Verifying this change

Add new tests to verify exchange bind exchange command, make sure producing and consuming is ok.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@gaoran10 gaoran10 requested review from codelipenghui and a team as code owners October 20, 2022 09:13
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants