Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to remove table boarder for the output #1240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to remove table boarder for the output #1240

wants to merge 2 commits into from

Conversation

zymap
Copy link
Member

@zymap zymap commented Oct 18, 2023

Master issue

#1237

Motivation

Support output the table without boarder line

@zymap zymap requested a review from ericsyh October 18, 2023 09:36
@zymap zymap self-assigned this Oct 18, 2023
@github-actions
Copy link

@zymap:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Oct 18, 2023
@zymap
Copy link
Member Author

zymap commented Oct 18, 2023 •
edited

The output will be like this:

                             TOPIC NAME                                  PARTITIONED ?  
  persistent://public/default/testing-iceberg-yong                       Y              
  persistent://public/default/testing-iceberg-yong-new                   Y              
  persistent://public/default/testing-iceberg-yong-new1                  Y              
  persistent://public/default/testing-iceberg-yong-new2                  Y              
  persistent://public/default/__change_events                            N              
  persistent://public/default/testing-iceberg-yong-new-partition-0       N              
  persistent://public/default/testing-iceberg-yong-new-partition-1       N              
  persistent://public/default/testing-iceberg-yong-new1-partition-0      N              
  persistent://public/default/testing-iceberg-yong-new1-partition-1      N              
  persistent://public/default/testing-iceberg-yong-new1-partition-2      N              
  persistent://public/default/testing-iceberg-yong-new2-partition-0      N              
  persistent://public/default/testing-iceberg-yong-new2-partition-1      N              
  persistent://public/default/testing-iceberg-yong-new2-partition-2      N              
  persistent://public/default/testing-iceberg-yong-partition-0           N              
  persistent://public/default/testing-iceberg-yong-partition-1           N

@zymap
Add option to remove table boarder for the output
ebc0c86 
---

### Master issue
streamnative#1237

### Motivation
Support output the table without boarder line
@zymap zymap force-pushed the provide-option-to-remove-boarder branch from ab06102 to ebc0c86 Compare October 18, 2023 09:40
mattisonchao
mattisonchao previously approved these changes Mar 9, 2024
View reviewed changes
@zymap @mattisonchao
Update pkg/ctl/topic/list.go
08ffc49 
Co-authored-by: Qiang Zhao <mattisonchao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao left review comments

@ericsyh ericsyh Awaiting requested review from ericsyh

@nlu90 nlu90 Awaiting requested review from nlu90 nlu90 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@zymap zymap

Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zymap @mattisonchao