-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitQuery Gradle plugin for syncing .proto files #57
Add GitQuery Gradle plugin for syncing .proto files #57
Conversation
ec6a68b
to
17b0570
Compare
cfc5f59
to
5dbbab6
Compare
@garyp do the failed conformance tests look right? |
cbbe214
to
7d7fa19
Compare
Bumped to 3.12.3. It breaks right now, but hopefully the artifact will be released soon |
proto 3.12.3 has been reverted to 3.12.2 protocolbuffers/protobuf#7632 |
7d7fa19
to
4ce2b17
Compare
@garyp this is good to go apart from the conformance tests. Can we ignore the failures? Also, we need to make sure that protoc is the same version as everything else, otherwise the Test.java will be different. Do you have any idea on how we would do that? A shell task perhaps? Granted I did update the readme to state that we need to have the right version installed so maybe that's good enough. |
I added the failures to the ignore lists for now. |
@garyp would be super cool if we could merge this |
@garyp any thoughts on this? |
@tinder-aminghadersohi Sorry I haven't had time to look at this yet. Hoping to get to it soon. Regarding your question about the |
@garyp oh totally understand. Awesome that you have the Test.java fix. In the meanwhile, I'll see if there is a newer protobuf aka 3.12.3 that was(is still?) missing from maven |
bebb067
to
4a2cbcc
Compare
66b054b
to
7f23192
Compare
updated to proto 3.13.0 |
GitQuery makes it easier to sync .proto files. We can chose to checkin the synced files, or not. Currently, since the generated kotlin is checked in, the proto files are git ignored.
Update all modules to use it.