Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitQuery Gradle plugin for syncing .proto files #57

Closed

Conversation

tinder-aminghadersohi
Copy link
Contributor

@tinder-aminghadersohi tinder-aminghadersohi commented Jun 7, 2020

GitQuery makes it easier to sync .proto files. We can chose to checkin the synced files, or not. Currently, since the generated kotlin is checked in, the proto files are git ignored.
Update all modules to use it.

  • conformance/lib/gitquery-proto.yml
  • examples/browser-js/gitquery-proto.yml
  • examples/custom-service-gen/application/gitquery-proto.yml
  • examples/gradle-and-jvm/gitquery-proto.yml
  • protoc-gen-kotlin/lib/gitquery-proto.yml
  • runtime/gitquery-proto.yml
  • pumb version of proto everywhere to 3.12.2

@tinder-aminghadersohi tinder-aminghadersohi changed the title Add GitQuery Gradle plugin for syncing WKT .protos files Add GitQuery Gradle plugin for syncing .protos files Jun 7, 2020
@tinder-aminghadersohi
Copy link
Contributor Author

@garyp do the failed conformance tests look right?

@tinder-aminghadersohi tinder-aminghadersohi changed the title Add GitQuery Gradle plugin for syncing .protos files Add GitQuery Gradle plugin for syncing .proto files Jun 15, 2020
@tinder-aminghadersohi
Copy link
Contributor Author

Bumped to 3.12.3. It breaks right now, but hopefully the artifact will be released soon

@tinder-aminghadersohi
Copy link
Contributor Author

@tinder-aminghadersohi
Copy link
Contributor Author

proto 3.12.3 has been reverted to 3.12.2 protocolbuffers/protobuf#7632

@tinder-aminghadersohi
Copy link
Contributor Author

tinder-aminghadersohi commented Jun 30, 2020

@garyp this is good to go apart from the conformance tests. Can we ignore the failures? Also, we need to make sure that protoc is the same version as everything else, otherwise the Test.java will be different. Do you have any idea on how we would do that? A shell task perhaps? Granted I did update the readme to state that we need to have the right version installed so maybe that's good enough.

@tinder-aminghadersohi
Copy link
Contributor Author

I added the failures to the ignore lists for now.

@tinder-aminghadersohi
Copy link
Contributor Author

@garyp would be super cool if we could merge this

@tinder-aminghadersohi
Copy link
Contributor Author

- GitQuery 2.0.0

@tinder-aminghadersohi
Copy link
Contributor Author

@garyp any thoughts on this?

@garyp
Copy link
Collaborator

garyp commented Jul 22, 2020

@tinder-aminghadersohi Sorry I haven't had time to look at this yet. Hoping to get to it soon. Regarding your question about the Test.java file, I actually ran into the same issue recently and have a fix for generating the Test.java file consistently in my other PR.

@tinder-aminghadersohi
Copy link
Contributor Author

@tinder-aminghadersohi Sorry I haven't had time to look at this yet. Hoping to get to it soon. Regarding your question about the Test.java file, I actually ran into the same issue recently and have a fix for generating the Test.java file consistently in my other PR.

@garyp oh totally understand. Awesome that you have the Test.java fix. In the meanwhile, I'll see if there is a newer protobuf aka 3.12.3 that was(is still?) missing from maven

@garyp garyp added this to the 0.9.0 milestone Sep 11, 2020
@garyp garyp added the enhancement New feature or request label Sep 11, 2020
@tinder-aminghadersohi
Copy link
Contributor Author

updated to proto 3.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants