handle private springs

see case of https://www.openstreetmap.org/note/3307888

app/src/main/java/de/westnordost/streetcomplete/quests/drinking_water/AddDrinkingWater.kt

@@ -32,10 +32,13 @@ class AddDrinkingWater : OsmFilterQuestType<DrinkingWater>() {
     override fun getHighlightedElements(element: Element, getMapData: () -> MapDataWithGeometry) =
         getMapData().filter("""
             nodes with
-             man_made = water_tap
-             or man_made = water_well
-             or natural = spring
-             or amenity = drinking_water
+             (
+                 man_made = water_tap
+                 or man_made = water_well
+                 or natural = spring
+                 or amenity = drinking_water
+             )
+             and access !~ private|no
         """)
 
     override fun createForm() = AddDrinkingWaterForm()

app/src/test/java/de/westnordost/streetcomplete/quests/drinking_water/AddDrinkingWaterTest.kt

@@ -0,0 +1,35 @@
+package de.westnordost.streetcomplete.quests.drinking_water
+
+import de.westnordost.streetcomplete.data.osm.edits.update_tags.StringMapEntryAdd
+import de.westnordost.streetcomplete.data.osm.edits.update_tags.StringMapEntryDelete
+import de.westnordost.streetcomplete.osm.SURVEY_MARK_KEY
+import de.westnordost.streetcomplete.osm.nowAsCheckDateString
+import de.westnordost.streetcomplete.quests.TestMapDataWithGeometry
+import de.westnordost.streetcomplete.quests.verifyAnswer
+import de.westnordost.streetcomplete.testutils.node
+import org.junit.Assert
+import org.junit.Test
+
+class AddDrinkingWaterTest {
+    private val questType = AddDrinkingWater()
+
+    @Test
+    fun `applicable to springs`() {
+        val mapData = TestMapDataWithGeometry(
+            listOf(
+                node(1, tags = mapOf("natural" to "spring")),
+            ),
+        )
+        Assert.assertEquals(1, questType.getApplicableElements(mapData).toList().size)
+    }
+
+    @Test
+    fun `not applicable to inaccessible springs`() {
+        val mapData = TestMapDataWithGeometry(
+            listOf(
+                node(1, tags = mapOf("natural" to "spring", "access" to "no")),
+            ),
+        )
+        Assert.assertEquals(0, questType.getApplicableElements(mapData).toList().size)
+    }
+}