Fix hanging builds #1193
Merged
Fix hanging builds #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an arbitrary feature (the supermoon toggle) introduced an extremely nasty bug where builds on Heroku hung indefinitely without warning. (This problem was not observed locally, on CI, or even on the staging server.) After narrowing the problem down to the import of a SCSS file, we discovered that the symptoms we very similar to this issue filed on the Parcel repository: parcel-bundler/parcel#1836, and confirmed that the issue is with the repeated import of
../../variables.scssinPaletteCommandsLeft.scss.This PR removes the temporary supermoon event, re-uses the supermoon toggle as a way to trigger the environment picker "easter egg," and fixes the build issue. Parcel recommends using the native-JS
sassmodule, rather than the older-but-apparently-problematicnode-sass. (more info). Note that this is necessary to achieve complete implementation of #1176, and this was a relatively simple switch assasswas already a dependency.While
sassis theoretically slower thannode-sass, we don't seem to notice any additional build time because of this switch.