chore(deps-dev): bump eslint-config-standard from 12.0.0 to 13.0.1 #1472
Conversation
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
|
Upgrading to the newest version of
The failing test on Travis CI will show exactly where our code will need to be updated. With the exception of the |
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-config-standard-13.0.1
branch
from
8800c4d
to
e74e222
Compare
|
@louh These rules all look good to me, and the inconvenience is worth it 👍let me know if I should go ahead and throw the requisite lint fixes into this branch. |
|
@whitmanschorn Yes if you can go ahead and make the lint fixes here that would be great! It would be good to have the green check mark on Travis before we merge. |
whitmanschorn
force-pushed
the
dependabot/npm_and_yarn/eslint-config-standard-13.0.1
branch
from
e74e222
to
6c56460
Compare
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
======================================
Coverage 34.6% 34.6%
======================================
Files 248 248
Lines 9182 9182
Branches 1986 1986
======================================
Hits 3177 3177
Misses 5401 5401
Partials 604 604
Continue to review full report at Codecov.
|
| @@ -24,15 +24,15 @@ async function readFlags (res) { | |||
| function sendSuccessResponse (res, flags) { | |||
| res.set({ | |||
| 'Content-Type': 'application/json; charset=utf-8', | |||
| 'Location': config.restapi.baseuri + '/v1/flags', | |||
| Location: config.restapi.baseuri + '/v1/flags', | |||
There was a problem hiding this comment.
I didn't realize we'd be as affected as we are by inconsistent quotation marks. I know there's some discussion here.
We could override standard's rule with eslint's consistent-as-needed rule, but the tradeoffs here are the addition of one more rule override and the need to re-quote entire objects if just one property is introduced that requires quotes.
@whitmanschorn do you have an opinion?
There was a problem hiding this comment.
I think I'm fine with this way, since it means putting quotes around a key is a good indicator that the key name has a non-standard character. Happy to do it either way, though.
There was a problem hiding this comment.
OK, we'll take the path of least resistance here.
Bumps [eslint-config-standard](https://github.com/standard/eslint-config-standard) from 12.0.0 to 13.0.1. - [Release notes](https://github.com/standard/eslint-config-standard/releases) - [Changelog](https://github.com/standard/eslint-config-standard/blob/master/CHANGELOG.md) - [Commits](standard/eslint-config-standard@v12.0.0...v13.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> lint fixes cleanup
whitmanschorn
force-pushed
the
dependabot/npm_and_yarn/eslint-config-standard-13.0.1
branch
from
3ffb88d
to
a9fad70
Compare
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/eslint-config-standard-13.0.1
branch
Bumps eslint-config-standard from 12.0.0 to 13.0.1.
Commits
f7c0fe113.0.1075f6abRelax rule: Only error in destructuring if all variables should be const (pre...e3e5dca13.0.0c82aa03Remove require-atomic-updates due to false positive risk62e933713.0.0-1532d389Disallow spaces inside of computed properties1bd2f52remove redundant standard-plugin rulesaf760f1bump eslint deps7b4aaab13.0.0-02558e02Disallow assignments that can lead to race conditions due to usage of await o...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @louh.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot ignore this [patch|minor|major] versionwill close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.