Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix backwards compatibility for Reporters #2229

Merged
merged 1 commit into from
Jan 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cspell-types/src/CSpellReporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export interface RunResult {
/** Number of processing errors. */
errors: number;
/** Number files that used results from the cache. */
cachedFiles: number;
cachedFiles?: number;
}

export type ResultEmitter = (result: RunResult) => void | Promise<void>;
Expand Down
2 changes: 1 addition & 1 deletion packages/cspell/src/lint/lint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export async function runLint(cfg: LintRequest): Promise<RunResult> {
for await (const fileP of loadAndProcessFiles()) {
const { filename, fileNum, result } = await fileP;
status.files += 1;
status.cachedFiles += result.cached ? 1 : 0;
status.cachedFiles = (status.cachedFiles || 0) + (result.cached ? 1 : 0);
emitProgress(filename, fileNum, result);
// Show the spelling errors after emitting the progress.
result.issues.filter(cfg.uniqueFilter).forEach((issue) => reporter.issue(issue));
Expand Down