apt-widget icon-control #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I am proposing a change in the apt-widget.lua code. As it is now the popup menu disappears when the pointer moves out of the popup area. If you wanted, for example, to complete some updates and watch the list shrink, you would have to hover over the popup. The moment your cursor leaves the popup area, it closes. I've added a variable called 'icon_control'. This variable can be set in the 'rc.lua' file as part of apt-widget. When set the popup does not close when you leave it with your mouse. The popup does close when the user clicks again on the icon. This is similar to the way that the file-system widget works. Of course if you leave it out of your config, the widget should still work. I was going to call the variable 'auto_close' but this would imply that the variable needed to be set for the old behavior to work, and I want it so that the old behavior is associated with no extra setting whatsoever. If this change is made, the readme file might need to be added to. This is a sort of feature request.