fix typos in comments and tests #1247
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisitsky
approved these changes
Aug 16, 2022
sebrandon1
approved these changes
Aug 16, 2022
|
Just finding back this old PR. Is there anything else needed ? |
|
@ccoVeille could you please fix conflicts? |
dolmen
previously approved these changes
Oct 30, 2023
|
I will |
|
Almost everything I reported in the initial MR were fixed by @alexandear via #1410 The changes remaining are very light, there are less important than when I reported the MR initially It's up to you to merge or close |
|
TIL behaviour is en-GB, we've got some more of those now in our issue templates. I believe we use en-US here. Can you give this a rebase and another search then I will gladly merge. |
|
here we are, I have just rebased and apply another round of modifications |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix typos in documentation, comments and tests
Motivation
I looked at the documentation, then found one typo in Panic: "functon" instead of "function"
So decided to check a bit further.
Changes
I used the following tools to validate the typos:
I applied automatic fixes, then reviewed them manually one by one, before committing and opening this PR
Related issues
None