Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock: optimize argument matching checks #1416

Merged
merged 2 commits into from Jan 21, 2024
Merged

mock: optimize argument matching checks #1416

merged 2 commits into from Jan 21, 2024

Commits on Oct 16, 2023

  1. mock: simplify Arguments.Diff 

    Use a type switch instead of reflect.TypeOf comparisons.
    @dolmen
    dolmen committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    413628c View commit details
    Browse the repository at this point in the history

  2. mock: refactor IsType 

    Reduce calls to reflect.Type in implementation of mock.IsType by
extracting the type early.

This also avoids to keep alive references to the argument value.
    @dolmen
    dolmen committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    307c934 View commit details
    Browse the repository at this point in the history