-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mock: fix FunctionalOptions docs #1433
Conversation
mock/mock.go
Outdated
// FunctionalOptions returns an FunctionalOptionsArgument object containing the functional option type | ||
// and the values to check of | ||
// FunctionalOptions returns an FunctionalOptionsArgument object containing | ||
// the expected functional-options to check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing dot at the end of the sentence.
Also, add godoc link.
Please squash commits and be more careful about the commit message. |
fc17507
to
cd1effb
Compare
Hi @dolmen , can you please review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commit message: "remove old input args" is not helpful in the project history.
Use instead: "assert.FunctionalOptions: fix go doc"
05c6a3b
to
4ac55f1
Compare
Summary
the comment about this function is not updated with the final implementation
Changes
just the comment above the func
Motivation
its misleading
Related issues
some relevant links to the PR that added
FunctionalOptions
#1023
suggestion 1
suggestion 2