Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency cycle with objx #1292 #1453

Merged
merged 2 commits into from Jan 21, 2024
Merged

Fix dependency cycle with objx #1292 #1453

merged 2 commits into from Jan 21, 2024

Commits on Aug 9, 2023

  1. deps: upgrade objx to v0.5.1 to fix dep cycle 

    See stretchr/objx#140

go get github.com/stretchr/objx@v0.5.1
    @dolmen
    dolmen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    975128c View commit details
    Browse the repository at this point in the history

  2. deps: exclude old testify to break the dependency cycle from objx 

    In go.mod exclude the old version of testify brought by objx. This
allows to break the dependency cycle and completely remove the
dependency link to old versions of dependencies (some of which had
security issues).

Closes #1292.

go mod edit -exclude=github.com/stretchr/testify@v1.8.2 && go.mod
    @dolmen
    dolmen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    838caea View commit details
    Browse the repository at this point in the history