assert.InEpsilonSlice: include msgAndArgs on failed assertion #1454
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
requested changes
Aug 11, 2023
|
Hi @dolmen, thank you for the quick review!
Can you provide more details about which regression tests you are referring to in the |
|
Related: #1231 (also about |
The test that you didn't write! We need to augment |
dolmen
changed the title
VladPetriv
force-pushed
the
fix/pass-additional-arguments
branch
from
a2665e8
to
2be4cff
Compare
…reported in fail case
|
This blocked by #1483 that must be merged first. |
dolmen
requested changes
Oct 30, 2023
dolmen
requested changes
Oct 31, 2023
assert/assertions_test.go
Outdated
| @@ -1915,6 +1915,17 @@ func TestInEpsilonSlice(t *testing.T) { | |||
| 0.04), "{2.2, 2.0} is not element-wise close to {2.1, 2.1} in epsilon=0.04") | |||
|
|
|||
| False(t, InEpsilonSlice(mockT, "", nil, 1), "Expected non numeral slices to fail") | |||
|
|
|||
| inEpsilonSliceMockT := new(mockTestingT) | |||
There was a problem hiding this comment.
Rename the variable to mockT for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the
msgAndArgsparameter to theInEpsilonfunction for better error reporting in case of failed assertion.Related issues
Closes #1324