suite: fix subtest names (fix #1501) #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subtest of TestSubtestPanic is expected to fail, but that must not make the testuite of package 'suite' to fail. So call Skip to make 'go test' to ignore that expected failure.
We are doing dirty things with testing.InternalTest. It looks like test names should have the same prefix as the parent test, like if they were true subtests (testing.T.Run). So until we drop our usage of testing.InternamTest, let's rename the tests. Also added a few checks of the testing.RunTests result.
This was referenced Nov 2, 2023
dolmen
requested review from
ernesto-jimenez,
DAddYE,
mazondo,
matryer,
glesica,
mvdkleijn,
nelsam,
brackendawson,
georgelesica-wf,
bencampbell-wf,
boyan-soubachov and
MovieStoreGuy
|
Following my announcement on Slack, I'm pinging all other co-maintainers. |
craig65535
approved these changes
Nov 2, 2023
|
looks like the other maintainers are very slow to respond, I can help by opening the PR so you can approve and merge it instead (if you don't mind ofc) |
boyan-soubachov
approved these changes
Nov 9, 2023
|
Thanks @boyan-soubachov for the merge ! Thanks @hendrywiranto for giving a hand. Right now any review you could do on the long list of pending PRs would be useful (use the "Review" button in GitHub). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are doing dirty things with
testing.InternalTest. It looks like test names should have the same prefix as the parent test, like if they were true subtests (testing.T.Run). So until we drop our usage of testing.InternamTest, let's rename the tests.Changes
Motivation
CI failure (#1501).
Related issues