Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert.Regexp: handle []byte array properly #1587

Merged
merged 1 commit into from May 22, 2024
Merged

assert.Regexp: handle []byte array properly #1587

merged 1 commit into from May 22, 2024
+13 −2

Commits on Apr 17, 2024

  1. assert: handle []byte array properly 

    The regexp package works more efficiently on bytes; if you have bytes,
it is easier to pass these directly to assert.Regexp than to convert
them to a string first.

In addition, FindIndex/FindStringIndex are unnecessary here because we
immediately throw away the result - let's just call Match() instead.
    @kevinburkesegment
    kevinburkesegment committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a9e6121 View commit details
    Browse the repository at this point in the history