Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock: move regexp compilation outside of Called #631

Merged
merged 3 commits into from Aug 1, 2023
Merged

mock: move regexp compilation outside of Called #631

merged 3 commits into from Aug 1, 2023

Conversation

aud10slave
Copy link
Contributor

This diff moves the regular expression compilation for GCCGO functions outside the mock.Called. Its doing unnecessary work on every function call.

@dolmen dolmen changed the title Move regexp compilation outside of the function mock: move regexp compilation outside of Called Jul 31, 2023
dolmen
dolmen requested changes Jul 31, 2023
View reviewed changes
mock/mock.go Outdated Show resolved Hide resolved
dolmen
dolmen reviewed Jul 31, 2023
View reviewed changes
mock/mock.go Outdated Show resolved Hide resolved
dolmen
dolmen requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must squash commits.

@dolmen dolmen self-requested a review August 1, 2023 08:05
@dolmen dolmen merged commit a23f5db into stretchr:master Aug 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolmen dolmen dolmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aud10slave @dolmen