Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow KafkaRoller talk to controller directly #10016

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow KafkaRoller talk to controller directly #10016

wants to merge 1 commit into from

Conversation

tinaselenge
Copy link
Contributor

Type of change

Select the type of your PR

  • Enhancement / new feature

Description

  • Configure controller listener with pod DNS name so that AdminClient can bootstrap.
  • Add a method for creating admin client for controllers with BOOTSTRAP_CONTROLLERS_CONFIG set.
  • Make KafkaRoller create admin client against controllers nodes, if they are running 3.7.0 or later.
  • Tidy up: remove ceShouldBeFatal option as it's never set to true.

Closes #9692

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@tinaselenge tinaselenge force-pushed the add-controller-svc branch 2 times, most recently from c256f5a to 93053e7 Compare April 24, 2024 13:15
@see-quick see-quick mentioned this pull request Apr 25, 2024
Open
@tinaselenge tinaselenge mentioned this pull request May 14, 2024
Open
@tinaselenge tinaselenge force-pushed the add-controller-svc branch 2 times, most recently from c460398 to 1bf6fab Compare May 14, 2024 15:55
@tinaselenge
Allow KafkaRoller talk to controller directly
0f6d51f 
Configure controller listener with pod DNS name so that AdminClient can bootstrap.
Add a method for creating admin client for controllers with BOOTSTRAP_CONTROLLERS_CONFIG set.
Make KafkaRoller create admin client against pure controllers nodes, if they are running 3.7.0 or later.
Tidy up: remove ceShouldBeFatal option as it's never set to true.

Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KRaft]: Allow KafkaRoller directly connect to controllers
1 participant
@tinaselenge