[Fix] correct bridge env vars names for consumer and producer enabled #10120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kornel <kornys@outlook.com>
|
Its great that you noticed this issue. Thanks. But maybe its best to first start a discussion on Slack and see what @ppatierno as the SME thinks about it rather than madly opening conflicting PRs all over the place. |
Well I wanted to help and save time so I have opened PR in both repositories. SME can just pick what is better solution and close the second one. So I don't see any issue with this approach... |
Frawless
approved these changes
May 21, 2024
im-konge
approved these changes
May 21, 2024
im-konge
reviewed
May 21, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaBridgeCluster.java
Outdated
Show resolved
Hide resolved
|
I prefer this way, so fixing in the operator. |
ppatierno
approved these changes
May 21, 2024
Signed-off-by: David Kornel <kornys@outlook.com>
im-konge
approved these changes
May 21, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
We can rename env vars there or in bridge. please see this PR
related bridge issue strimzi/strimzi-kafka-bridge#900