Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website-frontend): add new repositories page #519

Merged
merged 14 commits into from
May 24, 2024

Conversation

xandervedder
Copy link
Collaborator

Minimal UX improvements, but it will fit better with the current styling.

@xandervedder
Copy link
Collaborator Author

It seems that I cannot run the e2e tests anymore, can you run them @hugo-vrijswijk? (I believe it might be because we are using npm workspaces now).

@hugo-vrijswijk
Copy link
Member

It seems that I cannot run the e2e tests anymore, can you run them @hugo-vrijswijk? (I believe it might be because we are using npm workspaces now).

Locally? I can still run them (though I'm getting a lot of errors, maybe there should be something in the contributing.md on how to run them 😄). In CI they're running fine too. What is not working for you?

@xandervedder
Copy link
Collaborator Author

xandervedder commented Mar 17, 2024

I get the following (tested with 2 different machines, and with a fresh clone):

node:internal/modules/cjs/loader:1152
  throw err;
  ^

Error: Cannot find module '/../Stryker/stryker-dashboard/packages/e2e/node_modules/playwright-core/cli.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1149:15)
    at Module._load (node:internal/modules/cjs/loader:990:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}


It seems like the command used to run tests (in the tasks.json) is no longer correct, so I will have to fix that.

@xandervedder
Copy link
Collaborator Author

Got the tests running and made a new issue for improving this cumbersome workflow: #550, still need to fix the actual tests + add the badge config thingy back on this page.

@xandervedder
Copy link
Collaborator Author

xandervedder commented May 23, 2024

Small TODO list:

  1. Make repositories clickable so that it navigates the user to the report.
  2. For now, since we do not have an api for getting (only) the mutation score, place the badge inside the sme-report component

Done now

@xandervedder xandervedder merged commit 29b65dd into master May 24, 2024
3 checks passed
@xandervedder xandervedder deleted the feat/repository-page branch May 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Everything that has to do with the frontend of the dashboard
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants