Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies + fix issues related with that #1589

Closed
bartekleon opened this issue Jun 17, 2019 · 1 comment
Closed

Update dependencies + fix issues related with that #1589

bartekleon opened this issue Jun 17, 2019 · 1 comment

Comments

@bartekleon
Copy link
Member

bartekleon commented Jun 17, 2019

By mistake, I have updated some of the files (it was typescript), and after some bug fixing related to that, I have noticed that you are missing a lot of @types and most of them are obsolete!
for example:
currently installed

"@types/glob": "^7.1.0",
"@types/istanbul": "^0.4.29",
"@types/karma": "^3.0.0",
"@types/lodash": "^4.14.110",
"@types/mkdirp": "^0.5.2",
"@types/mocha": "^2.2.44",
"@types/node": "^10.11.5",
"@types/rimraf": "2.0.2",
"@types/sinon": "5.0.5",
"@types/sinon-chai": "^3.2.0"

current:

"@types/glob": "^7.1.1",
"@types/istanbul": "^0.4.30",
"@types/karma": "^3.0.3",
"@types/lodash": "^4.14.134",
"@types/mkdirp": "^0.5.2",
"@types/mocha": "^5.2.7",
"@types/node": "^10.11.5",
"@types/rimraf": "2.0.2",
"@types/sinon": "7.0.13",
"@types/sinon-chai": "^3.2.2",

some of them don't have super changes but other like sinon / mocha are quite obsolete
+ you in one package i have noticed you don't use @types for jest (it can cause some type error in the future)

@nicojs
Copy link
Member

nicojs commented Jun 24, 2019

With regards to TypeScript 3.5, I'm waiting for the fix for microsoft/TypeScript#31676 to be released (will hopefully be 3.5.2). After that I we will be able to update TypeScript itself.

TL;DR;
I'm happy to accept a PR that changes all ^ (minor version) ranges to ~ (patch version) ranges. For more info on ^ and ~ see https://docs.npmjs.com/about-semantic-versioning#using-semantic-versioning-to-specify-update-types-your-package-can-accept.
I'm also happy to accept a PR for mocha types.

Long version:

With regards to the @types dependencies, they're not exactly "obsolete". We're using dependabot to automagically update our dependencies. The thing is, it will only create a PR if the new version is outside of the semver range. For example "@types/lodash": "^4.14.134", is still in ranche of "@types/lodash": "^4.14.110", and so it will not create a PR for it. We're also happy with not following patch releases as it would create a lot of PR's.

I would agree that we should never use ^, instead use ~. That way we will get a PR for minor releases.

The only one that is really outdated are mocha and sinon. Updating sinon will be a lot fo work because of this issue: DefinitelyTyped/DefinitelyTyped#36019. I'm not sure why mocha isn't updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants