Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: change ^ to ~ in packages #1608

Closed
wants to merge 2 commits into from
Closed

maintenance: change ^ to ~ in packages #1608

wants to merge 2 commits into from

Conversation

bartekleon
Copy link
Member

Partially solves #1589.
Still not updated packages:
stryker\packages\core\package.json - @stryker-mutator/api
stryker\e2e\package.json - @types/semver, semver, ts-node, typescript, webpack
stryker\package.json - @types/mocha, @types/sinon, execa, tslint, typescript
(i still might be missing some)

Important to change:
stryker\packages\core\package.json - @stryker-mutator/api
stryker\package.json - @types/mocha, @types/sinon
But it will cause a lot of issues (It might be a PR more than 1 person should work)

less important but still: tslint, typescript
will cause more issues :/

Note:
Stryker supports node >= 8.
But we are using types for node 10.x.x
should we change it to 8.x.x for now, until support for 8 is dropped?

@bartekleon
Copy link
Member Author

bartekleon commented Jul 1, 2019

@nicojs little guy is waiting for the approval :x

@sanderkoenders
Copy link
Member

We just merged some dependabot stuff, could you update the pull-request 🙈

@bartekleon
Copy link
Member Author

bartekleon commented Aug 8, 2019

@nicojs, @simondel, @Archcry could we please wait with updating dependencies until we fix this issue? :)
we will be able to fix: #1589, #1587, #1595 at once

@nicojs
Copy link
Member

nicojs commented Aug 27, 2019

Stryker supports node >= 8.
But we are using types for node 10.x.x
should we change it to 8.x.x for now, until support for 8 is dropped?

No, we shouldn't change it to 8.x.x. We did this practice in the past, however as the typings for 8.x.x are effectively frozen we don't get all the awesome typing improvements the good guys over at definitely typed provide. That's why we use the latest typings and run indeed the risk of using something that we shouldn't. We trust our tests enough.

Will merge after conflicts are solved

@bartekleon bartekleon closed this Sep 7, 2019
@bartekleon bartekleon deleted the fix-#1589 branch September 7, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants