New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(presets): update init
templates for 4.0 release
#2526
Conversation
Update the vuejs, react and angular presets for the 4.0 release.
I've updated the presets in this PR. There is however an issue with the vuejs preset. The VueJS preset is quite old. It actually is not compatible with the vue cli. If you want to get your vue cli project to work with Stryker, your best chance at the moment is to look at our e2e tests (so either But, what to do with the vue preset in the meantime? 🤷♂️ |
neat! So much code went out. |
I disagree. Quite a lot needs to be done to make vue work with mocha actually.
Even with this, it might not work as expected, because there are still differences between Stryker's way of running the tests and vue-cli way of running it. Basically, vue-cli it is a big mess IMHO. Vue cli uses At this point, I feel like we have 3 options.
|
Oww... i havent checked Mocha yet. Only Jest since we have jest tests for vue :/ I think we should just make another E2E, VUE + Mocha, and if someones uses CLI it should just point to that package. At least for now |
What's wrong with the existing one? |
@nicojs Does the situation improve now Vue v3 is live? |
Nope they're still using the mochapack spaghetti |
"Quite a lot needs to be done to make vue work with mocha actually." |
I've updated the vuejs guide: https://github.com/stryker-mutator/stryker-handbook/blob/master/stryker/guides/vuejs.md#vuejs and I've updated the vue templates that are generated when a user chooses mocha. I've managed to remove step 2: "Create a custom "test.js" with the following content: ", but I'm still not happy with the result. At least it does work with a standard vue-cli project a.t.m. IMO we can release v4 with this... I guess. |
I tried my best, but I cannot bend steel with my bare hands 😑 |
Update the VueJS, react and angular presets for the 4.0 release.
Closes #2521