Feature: file upload #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I decided to upload files via graphql, and not separately with usual controllers. So I did some research and found some helpful links:
As there is no possibility to add a middleware from outside of this library, I thought it would be cool, if implementation would be in the library directly.
The implementation of support for multipart request ist pretty simple (thanks to graphql-upload). With adoption to laravel specific classes it works like a charm (thanks to laravel-graphql-upload)
I currently have 3 PR - there are a little merge conflict (some empty lines were removed/added, and git cant handle it...), so when the stages comes, that master is not compatible with this PR, I'll do a new merge.
If you have some improvement ideas, let me know