fix: add missing start_url to webmanifest #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XhmikosR is attempting to deploy a commit to the Package Phobia Team on Vercel. A member of the Team first needs to authorize it. |
XhmikosR
commented
Apr 20, 2024
| @@ -13,6 +13,7 @@ | |||
| "type": "image/png" | |||
| } | |||
| ], | |||
| "start_url": "/?utm_source=a2hs", | |||
There was a problem hiding this comment.
We can drop the query params if you prefer.
On which platform? Any docs on this? |
|
Oh interesting, I see the warning in chrome dev tools. There are a few others too. 
|
styfle
approved these changes
Apr 20, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Add to home screen. You can drop the query altogether if you prefer since
it's only for analytics
…On Sat, Apr 20, 2024, 18:52 Steven ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In public/site.webmanifest
<#1043 (comment)>
:
> @@ -13,6 +13,7 @@
"type": "image/png"
}
],
+ "start_url": "/?utm_source=a2hs",
What is a2hs?
—
Reply to this email directly, view it on GitHub
<#1043 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNJ4IJID3BNRJPXZTNDY6KFL3AVCNFSM6AAAAABGQGAR4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJTGEYDQNZYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that right now without
start_urlthe PWA is not installable. This should hopefully fix the issue.